[WIP] MIR move elimination pass#156046
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 884fdb2 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
This comment has been minimized.
This comment has been minimized.
|
💔 Test for b42852b failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
|
💔 Test for 8165e10 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (6c29ee1): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.4%, secondary 0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.5%, secondary 0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.5%, secondary 1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 512.33s -> 496.036s (-3.18%) |
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[WIP] MIR move elimination pass
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (03cc207): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.7%, secondary -1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -1.6%, secondary 0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.9%, secondary 1.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 523.273s -> 506.943s (-3.12%) |
This comment has been minimized.
This comment has been minimized.
This is no longer true as of rust-lang#107267.
- Changed `iter_intervals` to return `RangeInclusive` instead of `Range` - Added `clear_row`, `disjoint_rows` and `intersects_range` methods
This flag also has the effect of disabling DestinationPropagation, which is already covered by move elimination.
343333e to
f12157e
Compare
|
Closed in favor of #157943 so reviewers don't need to wade through 100+ CI/bors/perf messages. |
View all comments
This is very much a work in progress.